[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadf3c27742ed: [clang][cli] Revert accidental access-control flag rename (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

jansvoboda11 added a comment. > (Or maybe OptOutFFLag could reject an option beginning with `"no-"`?) I think this is reasonable. I'll reach out to the mailing list to see if there's a way to add assertions to TableGen that would catch this. > Thanks! Sorry for the breakage. No problem. Repo

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

MaskRay accepted this revision. MaskRay added a comment. Thanks! Sorry for the breakage. Actually, neither `-fno-access-control` nor `-faccess-control` has any test.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93104/new/ https://reviews.llvm.or

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

dexonsmith added a reviewer: MaskRay. dexonsmith added a comment. In D93104#2449787 , @dexonsmith wrote: > In D93104#2449783 , @dexonsmith > wrote: > >> LGTM. BTW, for partial reverts or potentially time-sensitive

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

dexonsmith added a comment. In D93104#2449783 , @dexonsmith wrote: > LGTM. BTW, for partial reverts or potentially time-sensitive fixes like this, > it's usually better to land first and ask questions later. (It'd be nice to have a test for this too if p

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. BTW, for partial reverts or potentially time-sensitive fixes like this, it's usually better to land first and ask questions later. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit https://reviews.llvm.org/rGe5158b52730d323bb8cd2cba6dc6