[PATCH] D93084: [VE] Optimize toolchain regression test

kaz7 added a comment. Thank you so much too. I could learn how to write better clang tests. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93084/new/ https://reviews.llvm.org/D93084 ___ cfe-commits

[PATCH] D93084: [VE] Optimize toolchain regression test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d1729232cd: [VE] Optimize toolchain regression test (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D93084: [VE] Optimize toolchain regression test

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks. The tests still work fine on my machine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93084/new/ https://reviews.llvm.org/D93084 ___

[PATCH] D93084: [VE] Optimize toolchain regression test

kaz7 updated this revision to Diff 311423. kaz7 added a comment. Rebase and update following suggestions. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93084/new/ https://reviews.llvm.org/D93084 Files: clang/test/Driver/Inputs/basic_ve_

[PATCH] D93084: [VE] Optimize toolchain regression test

kaz7 added a comment. Thank you for suggestions. Comment at: clang/test/Driver/ve-toolchain.cpp:115 +// DEF-SAME: "-z" "max-page-size=0x400" +// DEF-SAME: "crtbegin.o" +// DEF-SAME: "-lc++" "-lc++abi" "-lunwind" "-lpthread" "-ldl" MaskRay wrote: > You proba

[PATCH] D93084: [VE] Optimize toolchain regression test

MaskRay added inline comments. Comment at: clang/test/Driver/ve-toolchain.cpp:115 +// DEF-SAME: "-z" "max-page-size=0x400" +// DEF-SAME: "crtbegin.o" +// DEF-SAME: "-lc++" "-lc++abi" "-lunwind" "-lpthread" "-ldl" You probably should add an empty file in `basi

[PATCH] D93084: [VE] Optimize toolchain regression test

MaskRay added a comment. LG. I don't have a system VE toolchain and the tests still pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93084/new/ https://reviews.llvm.org/D93084 ___ cfe-commits mailing

[PATCH] D93084: [VE] Optimize toolchain regression test

kaz7 created this revision. kaz7 added reviewers: MaskRay, simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added a subscriber: ormris. kaz7 requested review of this revision. Herald added a subscriber: cfe-commits. Optimize toolchain regression test for VE by removing not a useful test