[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-15 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 ___ c

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-11 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added inline comments. Comment at: clang/test/OpenMP/target_defaultmap_codegen_01.cpp:1523 -// CK26-DAG: [[SIZES:@.+]] = {{.+}}constant [3 x i64] [i64 4096, i64 4, i64 {{.+}}] +// CK26-DAG: [[SIZES:@.+]] = {{.+}}constant [3 x i64] [i64 4, i64 4096, i64 {{.+}}] // Map t

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-10 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/test/OpenMP/target_defaultmap_codegen_01.cpp:1523 -// CK26-DAG: [[SIZES:@.+]] = {{.+}}constant [3 x i64] [i64 4096, i64 4, i64 {{.+}}] +// CK26-DAG: [[SIZES:@.+]] = {{.+}}constant [3 x i64] [i64 4, i64 4096, i64 {{.+}}] // Map

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-09 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-03 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3490 +OMPC_MAP_MODIFIER_present); +ImplicitMapModifierLoc[ClauseKind].push_back(SourceLocation()); + } cchen wrote: > ABataev wrote: > > Why need to add

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-03 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 309292. cchen added a comment. Update based on comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 Files: clang/include/clang/Basic/OpenMPKinds.def clang/lib/Sema

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-02 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3490 +OMPC_MAP_MODIFIER_present); +ImplicitMapModifierLoc[ClauseKind].push_back(SourceLocation()); + } ABataev wrote: > Why need to add an empty `SourceLoc

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3310 + case OMPC_DEFAULTMAP_MODIFIER_present: +// If implicit-behavior is present, each variable referenced in the +// construct in the category specified by variable-category is treated as if

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-01 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added a comment. I now only update `target_defaultmap_messages` test since I'm not sure what I've done is correct for the new version. Will add all other defaultmap_messages tests once corrected the stuff I added in `target_defaultmap_messages`. Repository: rG LLVM Github Monorepo CH

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-01 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 308760. cchen added a comment. Rebase and fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 Files: clang/include/clang/Basic/OpenMPKinds.def clang/lib/

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-01 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Support present modifier in defaul