[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1df0677e6ac6: [clangd] Add language metrics for recovery AST usage. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92157/new/ https://r

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:44 +return; + const char *LanguageLabel = Lang.CPlusPlus ? "C++" : Lang.ObjC ? "ObjC" : "C"; static constexpr trace::Metric SelectionUsedRecovery( sammccall wrote: > This cl

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Selection.cpp:44 +return; + const char *LanguageLabel = Lang.CPlusPlus ? "C++" : Lang.ObjC ? "ObjC" : "C"; static cons

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:41 +const char *getLanguage(const clang::LangOptions &Lang) { + if (Lang.C99 || Lang.C11 || Lang.C17 || Lang.C2x) +return "C"; sammccall wrote: > Testing for specific C versions

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein updated this revision to Diff 309817. hokein marked 2 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92157/new/ https://reviews.llvm.org/D92157 Files: clang-tools-ex

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:41 +const char *getLanguage(const clang::LangOptions &Lang) { + if (Lang.C99 || Lang.C11 || Lang.C17 || Lang.C2x) +return "C"; Testing for specific C versions seems a bit wei

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:40 +std::string getLanguage(const clang::LangOptions &Lang) { + if (Lang.C99 || Lang.C11 || Lang.C17 || Lang.C2x) njames93 wrote: > Nit: a

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein updated this revision to Diff 307852. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92157/new/ https://reviews.llvm.org/D92157 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra/clan

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:40 +std::string getLanguage(const clang::LangOptions &Lang) { + if (Lang.C99 || Lang.C11 || Lang.C17 || Lang.C2x) Nit: any reason to use std::string here instead StringRef. R

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:51 // Measure the fraction of selections that were enabled by recovery AST. -void recordMetrics(const SelectionTree &S) { +void recordMetrics(const SelectionTree &S, const ASTContext &AST) { st

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://revie