hokein added inline comments.

================
Comment at: clang-tools-extra/clangd/Selection.cpp:44
+    return;
+  const char *LanguageLabel = Lang.CPlusPlus ? "C++" : Lang.ObjC ? "ObjC" : 
"C";
   static constexpr trace::Metric SelectionUsedRecovery(
----------------
sammccall wrote:
> This classifies objc++ as c++.
> Not necessarily a problem, up to you
yeah, this is my intention as we don't really care about C++ or ObjC++. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92157/new/

https://reviews.llvm.org/D92157

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to