[PATCH] D91925: [clangd][NFC] Small tweak to combined provider

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a0528e4a0e3: [clangd][NFC] Small tweak to combined provider (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D91925: [clangd][NFC] Small tweak to combined provider

njames93 added a comment. In D91925#2439666 , @sammccall wrote: > (I'm not sure how it resolves the problem, but certainly looks nicer!) It's something to do with the derived to base unique_ptr conversion not working properly with NRVO. However removing

[PATCH] D91925: [clangd][NFC] Small tweak to combined provider

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (I'm not sure how it resolves the problem, but certainly looks nicer!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91925/new/ https://re

[PATCH] D91925: [clangd][NFC] Small tweak to combined provider

njames93 updated this revision to Diff 309486. njames93 added a comment. Removed const qualifier on Providers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91925/new/ https://reviews.llvm.org/D91925 Files: clang-tools-extra/clangd/ConfigProvide

[PATCH] D91925: [clangd][NFC] Small tweak to combined provider

njames93 created this revision. njames93 added reviewers: sammccall, Bigcheese. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. njames93 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This should address the