njames93 added a comment.

In D91925#2439666 <https://reviews.llvm.org/D91925#2439666>, @sammccall wrote:

> (I'm not sure how it resolves the problem, but certainly looks nicer!)

It's something to do with the derived to base unique_ptr conversion not working 
properly with NRVO.
However removing the named variable should elide that, and as an added bonus it 
does look neater.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91925/new/

https://reviews.llvm.org/D91925

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to