This revision was automatically updated to reflect the committed changes.
Closed by commit rGdad804a193ed: [clangd] Improve clangd-indexer performance
(authored by ArcsinX).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91051/new/
https://reviews.ll
ArcsinX updated this revision to Diff 304262.
ArcsinX added a comment.
Don't check that `AbsPath` is not in `Files` twice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91051/new/
https://reviews.llvm.org/D91051
Files:
clang-tools-extra/clangd/i
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
Looks like everyone thinks that this sounds reasonable. So LGTM. Thanks for the
patch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91051/n
ArcsinX added a comment.
Thanks you all for your comments.
I will try to describe my thoughts:
- the more data `SymbolCollector` will collect, the greater the difference (`N`
will increase in `this patch improves performance in N times`). E.g. collection
call/contain relations will affect `cla
sammccall added a comment.
This seems like an accuracy/latency tradeoff in an environment where... it's
not clear why we care about latency very much. Do we?
OTOH, how useful is it to have a static index that's more accurate if it's
going to be shadowed by a dynamic index for the files you care
hokein added inline comments.
Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:46
Opts.CountReferences = true;
+Opts.FileFilter = [&](const SourceManager &SM, FileID FID) {
+ const auto *F = SM.getFileEntryForID(FID);
kadircet wrote:
> t
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:46
Opts.CountReferences = true;
+Opts.FileFilter = [&](const SourceManager &SM, FileID FID) {
+ const auto *F = SM.getFileEntryForID(FID);
this changes the
ArcsinX created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
ArcsinX requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
This is a try to improve clangd-indexer tool performance:
- avoid proces
