ArcsinX added a comment.

Thanks you all for your comments.

I will try to describe my thoughts:

- the more data `SymbolCollector` will collect, the greater the difference (`N` 
will increase in `this patch improves performance in N times`). E.g. collection 
call/contain relations will affect `clangd-indexer` performance significantly 
while `clangd` background indexer will not have such huge affection.
- performance improvement will help to update the index file more often (for 
remote server scenario). I mean an index file will be up to date every `K` 
commits instead of every `3 x K` commits (assume constant time difference 
between commits)
- the behavior with this patch is basically the same as clangd background 
indexer behavior.

If this patch could not be approved as is, then maybe we could add command line 
option to switch old/new behavior. What do you think? (Сan't think of a 
suitable name for this option =))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91051/new/

https://reviews.llvm.org/D91051

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to