[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9ef6bc42643: [clang] Disable LTO and LLD on SystemZ for stage3 builds (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D8

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

beanz accepted this revision. beanz added a comment. LGTM. The `*_LTO` and `*_LLD` variables are usable independently of each other even on non-Apple platforms, so it makes sense to need to set them both. LLVM’s LTO is supported in Gold, and I believe our build system supports MSVC’s LTCG (whi

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder updated this revision to Diff 331246. tbaeder added a comment. Here's a version that shells out to `uname -m` to get the arch. Setting both the `_LLD` and `_LTO` variable that often looks a bit odd but I didn't want to use other variables. Can change that of course. CHANGES SINCE LAST

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder added a comment. Including `CMakeDetermineSystem` gives me: loading initial cache file ../clang/cmake/caches/3-stage.cmake CMake Error: Could not open file for write in copy operation /CMakeSystem.cmake.tmp CMake Error: : System Error: Permission denied CMake Error at /usr/share/

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

beanz added a comment. If you add `include(CMakeDetermineSystem)` to the top of the cache file, it should initialize `CMAKE_HOST_SYSTEM_PROCESSOR`, which also probably gives you a reasonable value to key off. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89942/new/ https://reviews.llv

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

beanz added a comment. In D89942#2629184 , @tbaeder wrote: > But that's not true. The `3-stage-base.cmake` sets > `BOOTSTRAP_LLVM_ENABLE_LTO` to `ON`, which doesn't work on SystemZ. This is > the initial problem I had. I was not interested in having LTO

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder added a comment. In D89942#2629146 , @beanz wrote: > If we know SystemZ + LLD + LTO is a bad configuration, "fixing" the > configuration and logging a message seems like the wrong move when the only > way to get into that state is to specifically

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

beanz added a comment. I'm super sorry to be popping in so late on this. Is this really the direction we should take? If we know SystemZ + LLD + LTO is a bad configuration, "fixing" the configuration and logging a message seems like the wrong move when the only way to get into that state is to

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder updated this revision to Diff 330954. tbaeder added a comment. Dropped the `FORCE` stuff since we can just set the variable directly and that shouldn't make a difference as far was I know. And the warning now only appears if either LTO or LLD are enabled. CHANGES SINCE LAST ACTION ht

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added inline comments. Comment at: clang/CMakeLists.txt:639 + # We want LLD for LTO, but LLD does not support SystemZ, so disable + # LTO here and use the installed system linker + if ("${LLVM_NATIVE_ARCH}" MATCHES "SystemZ") I guess you're u

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder updated this revision to Diff 329309. tbaeder added a comment. Just re-tested this on a SystemZ machine and found that the `set()` in `clang/CMakeLists.txt` were not actually being applied. I also made it disable LLD on SystemZ as well, as you suggested. And I added a warning when `BOOT

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. @tbaeder sorry for the delay. I don't see any reason why we should keep that one in review any longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added a comment. @beanz This patch looks good to me, can you confirm? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89942/new/ https://reviews.llvm.org/D89942 ___ cfe-commits mailing li

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added inline comments. Comment at: clang/CMakeLists.txt:668 +message(STATUS "Using system linker for stage3 builds on Apple") +set(BOOTSTRAP_LLVM_ENABLE_LLD OFF CACHE BOOL "") + else() Should you also disable LTO here? Repository: r

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder created this revision. tbaeder added a reviewer: serge-sans-paille. Herald added subscribers: cfe-commits, pengfei, kristof.beyls, inglorion, mgorny. Herald added a project: clang. tbaeder requested review of this revision. I tried doing a stage3 build on SystemZ/s390 but ran into the unf