tbaeder added a comment.

In D89942#2629146 <https://reviews.llvm.org/D89942#2629146>, @beanz wrote:

> If we know SystemZ + LLD + LTO is a bad configuration, "fixing" the 
> configuration and logging a message seems like the wrong move when the only 
> way to get into that state is to specifically request options.

But that's not true. The `3-stage-base.cmake` sets `BOOTSTRAP_LLVM_ENABLE_LTO` 
to `ON`, which doesn't work on SystemZ. This is the initial problem I had. I 
was not interested in having LTO enabled or not, but the cache enables it and 
that breaks on SystemZ.

> It seems to me, your intent is to make the stage3 build work for SystemZ, and 
> that seems like something we should accomplish entirely inside the stage3 
> CMake caches.

I vaguely remember trying to do all this in the `3-stage-base.cmake` but things 
like `LLVM_NATIVE_ARCH` etc. are not available in there, I am not sure if the 
previous `if(APPLE)` check was working either.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89942/new/

https://reviews.llvm.org/D89942

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to