[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG76e85ae268f8: [clang][Sparc] Default to -mcpu=v9 for Sparc V8 on Solaris (authored by ro). Repository: rG LLVM Github M

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. Ping? It's been a week and AFAICT there's nothing left for me to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-commits mailing

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. Is there anything left to do to get approval? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-commits mailing list cfe-commit

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro updated this revision to Diff 289658. ro added a comment. Add FIXME for SparcV8 `MaxAtomicInlineWidth`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 Files: clang/lib/Basic/Targets/Sparc.cpp clang/

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } ro wrote: > efriedma wrote: > > ro wrote: > > > efriedma wrote: > > > > ro wrote: > > > > > efriedma wrote: >

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } efriedma wrote: > ro wrote: > > efriedma wrote: > > > ro wrote: > > > > efriedma wrote: > > > > > ro wrote: > > > >

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } ro wrote: > efriedma wrote: > > ro wrote: > > > efriedma wrote: > > > > ro wrote: > > > > > efriedma wrote: >

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } efriedma wrote: > ro wrote: > > efriedma wrote: > > > ro wrote: > > > > efriedma wrote: > > > > > This probably sho

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > efriedma wrote: > > ro wrote: > > > brad wrote: > > >

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; efriedma wrote: > ro wrote: > > brad wrote: > > > ro wrote: > > >

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > brad wrote: > > ro wrote: > > > efriedma wrote:

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } ro wrote: > efriedma wrote: > > ro wrote: > > > efriedma wrote: > > > > This probably should be refactored so

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; brad wrote: > ro wrote: > > efriedma wrote: > > > Do we want to m

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } efriedma wrote: > ro wrote: > > efriedma wrote: > > > This probably should be refactored so the target-independent

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } ro wrote: > efriedma wrote: > > This probably should be refactored so the target-independent code generates

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > efriedma wrote: > > Do we want to make sparc and sp

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. In D86621#2249240 , @jrtc27 wrote: > Actually, `__sparcv8` is only for V8; if you have 32-bit V9 on Solaris it > defines `__sparcv8plus` _instead_: > > jrtc27@gcc-solaris11:~$ /opt/solarisstudio12.4/bin/cc -E - -xarch=v9 -m32 > -xdu

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

jrtc27 added a comment. Actually, `__sparcv8` is only for V8; if you have 32-bit V9 on Solaris it defines `__sparcv8plus` _instead_: jrtc27@gcc-solaris11:~$ /opt/solarisstudio12.4/bin/cc -E - -xarch=v9 -m32 -xdumpmacros &1 | grep sparc #define __sparcv8plus 1 #define __sparc 1 #define s

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro updated this revision to Diff 289128. ro added a comment. Define `__sparcv8` only on 32-bit Solaris/SPARC. Update testcase. Remove `XFAIL`s that only apply to `clang`/2-stage builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. In D86621#2247791 , @jrtc27 wrote: > GCC on Linux defines `__sparc_v9__` even with `-m32`. I don't know what > Solaris does but please don't break other operating systems just because > Solaris has broken headers that conflate the CPU

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. In D86621#2247786 , @efriedma wrote: > > For compiler-rt, the XFAILs should probably reflect whatever config the bot > is running. (Alternatively, you could use UNSUPPORTED, but that doesn't seem > warranted here.) That's been m

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

jrtc27 added a comment. And notably _doesn't_ define the V8 macros, which this patch then reintroduces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-co

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. GCC on Linux defines `__sparc_v9__` even with `-m32`. I don't know what Solaris does but please don't break other operating systems just because Solaris has broken headers that confl

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added a comment. > While the fix proper is trivial: just two lines in > lib/Driver/ToolChains/CommonArgs.cpp, finding the right place has been > nightmarishly difficult: I'd have expected handling of a Solaris/SPARC CPU > default in either of Solaris or SPARC specific files, but not de

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added reviewers: venkatra, efriedma. ro added a comment. Herald added a subscriber: danielkiss. Ping? It's been a week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. While doing 2-stage builds, the 2 `XFAIL`s due to Bug 42493 were required. However, I've since also done a 1-stage build with gcc 10, which shows Unexpectedly Passed Tests (2): UBSan-Standalone-sparc :: TestCases/Float/cast-overflow.cpp UBSan-Standalone-sparc :: Te

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro created this revision. ro added reviewers: brad, jyknight. ro added a project: clang. Herald added subscribers: Sanitizers, jfb, jrtc27, fedor.sergeev. Herald added a reviewer: jfb. Herald added a project: Sanitizers. ro requested review of this revision. Herald added a subscriber: dexonsmith.