[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher added a comment. @MyDeveloperDay looks like it's in master, thanks for committing for me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 ___ cfe-com

[PATCH] D86581: [clang-format] Handle shifts within conditions

MyDeveloperDay added a comment. @Saldivarcher this should be landed now, please validate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 ___ cfe-commits mailing l

[PATCH] D86581: [clang-format] Handle shifts within conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc81dd3d159ab: [clang-format] Handle shifts within conditions (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher added a comment. @MyDeveloperDay thanks for the kind words, it's much appreciated! I'm just glad I was able to help. Nope, I don't have commit access, can you do me the favor of commiting for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D86581: [clang-format] Handle shifts within conditions

MyDeveloperDay added a comment. @Saldivarcher do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 ___ cfe-commits mailing list cfe-commits@

[PATCH] D86581: [clang-format] Handle shifts within conditions

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I think this LGTM and the solution is much more elegant than mine! You were not stepping on my toes, I'm always happy for someone else to take things over and this is a much sm

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher added a comment. MyDeveloperDay, I added your tests. Sorry to step on your toes, I didn't know there was a patch open for this already :(. Yeah, JakeMerdichAMD, it's kinda tough to handle those types of cases without some sort of parsing. I'm glad you're working on that, and my cod

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher updated this revision to Diff 288013. Saldivarcher added a comment. Added some more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 Files: clang/lib/Format/TokenAnnotator.cpp clang/u

[PATCH] D86581: [clang-format] Handle shifts within conditions

JakeMerdichAMD added a comment. Agreed that this is a very nice solution for this case. LGTM too assuming it passes @MyDeveloperDay's tests. Minor heads up: there are still some cases I can dream up where we'd currently spit out invalid code from splitting a right shift even after this fix. Lon

[PATCH] D86581: [clang-format] Handle shifts within conditions

MyDeveloperDay added a comment. I think I like your solution better than mine D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer , could you look at my unit tests and consider

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher created this revision. Saldivarcher added a reviewer: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Saldivarcher requested review of this revision. In some situation shifts can be treated as a template, and is thus formatted as one. So, by doing