MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land.
I think this LGTM and the solution is much more elegant than mine! You were not stepping on my toes, I'm always happy for someone else to take things over and this is a much smarter solution than mine. This bug has been reported multiple times I think this is a good first step towards a solution, and I don't think "perfection should be the enemy of good", I think for most cases this will suffice. anything else more obtuse I wonder why people write code in that form when its hard for the non author to read, but we can address those cases when we hit them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
