mcgrathr added inline comments.
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1127
+ if (LangOpts.RelativeCXXABIVTables)
+Builder.defineMacro("__RELATIVE_CXX_ABI_VTABLES");
ldionne wrote:
> mcgrathr wrote:
> > This should also test `LangOpts.CplusPlu
mcgrathr added inline comments.
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1127
+ if (LangOpts.RelativeCXXABIVTables)
+Builder.defineMacro("__RELATIVE_CXX_ABI_VTABLES");
This should also test `LangOpts.CplusPlus` so it's never defined in C
compil
ldionne added inline comments.
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1127
+ if (LangOpts.RelativeCXXABIVTables)
+Builder.defineMacro("__RELATIVE_CXX_ABI_VTABLES");
Should we be using some `__has_feature(...)` instead?
Repository:
rG LLVM
leonardchan created this revision.
leonardchan added reviewers: mcgrathr, phosek.
leonardchan added a project: libc++abi.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
leonardchan requested review of this revision.
This will be set if relative vtables are enabled.
Reposi