mcgrathr added inline comments.

================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1127
 
+  if (LangOpts.RelativeCXXABIVTables)
+    Builder.defineMacro("__RELATIVE_CXX_ABI_VTABLES");
----------------
This should also test `LangOpts.CplusPlus` so it's never defined in C 
compilation.

I don't know what precedents there are to follow for how to choose the exact 
name here.
Having something like `__CXX_ABI_` be a prefix for all such things seems wise.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85924/new/

https://reviews.llvm.org/D85924

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to