[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-10-27 Thread Wei Wang via Phabricator via cfe-commits
weiwang closed this revision. weiwang added a comment. Diff was committed, but did not close automatically. Manual close it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 _

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-10-27 Thread Wei Wang via Phabricator via cfe-commits
weiwang updated this revision to Diff 301140. weiwang added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/opt-re

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-09-21 Thread Wei Wang via Phabricator via cfe-commits
weiwang updated this revision to Diff 293296. weiwang added a comment. minor update to test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/t

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-09-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:104 + CmdArgs.push_back(Args.MakeArgString( + Twine("--plugin-opt=opt-remarks-format=") + Format.data()));

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-09-21 Thread Wei Wang via Phabricator via cfe-commits
weiwang updated this revision to Diff 293276. weiwang added a comment. 1. remove unreachable code 2. udpate test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/Com

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-09-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:95 +if (F.empty()) + F = llvm::sys::path::stem(Input.getBaseInput()); + } Is the `F.empty()` case unreachable? Please delete the code or add an assert ==

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-09-17 Thread Wei Wang via Phabricator via cfe-commits
weiwang marked an inline comment as done. weiwang added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:90 + } else { +if (Output.isFilename()) + F = Output.getFilename(); MaskRay wrote: > The output selection logic is untested.

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-09-17 Thread Wei Wang via Phabricator via cfe-commits
weiwang updated this revision to Diff 292676. weiwang added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Drive

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-09-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:90 + } else { +if (Output.isFilename()) + F = Output.getFilename(); The output selection logic is untested. Comment at: clang/test/Driver/opt-record

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-09-17 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
thegameg accepted this revision. thegameg added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-08-27 Thread Wei Wang via Phabricator via cfe-commits
weiwang updated this revision to Diff 288447. weiwang added a comment. remove redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-08-27 Thread Wei Wang via Phabricator via cfe-commits
weiwang added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:596 + // Handle remark diagnostics on screen options: '-Rpass-*'. + if (usesRpassOptions(Args)) +renderRpassOptions(Args, CmdArgs); tejohnson wrote: > Is this guard needed

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-08-25 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. Looks pretty good but I think it can be simplified in one place as I note below. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:596 + // Handle remark diagnostics on screen options: '-Rpass-*'. + if (usesRpassOptions(Args)) +renderRpassO

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-08-18 Thread Wei Wang via Phabricator via cfe-commits
weiwang updated this revision to Diff 286468. weiwang marked an inline comment as done. weiwang added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/include/clang/Driver/

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-08-18 Thread Wei Wang via Phabricator via cfe-commits
weiwang marked 5 inline comments as done. weiwang added inline comments. Comment at: clang/include/clang/Driver/Driver.h:638 +/// This checks for clang specific R-value ('-Rpass-*') group. +bool hasRpassOptions(const llvm::opt::ArgList &Args); + bruno wrote: > Ni

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-08-18 Thread Wei Wang via Phabricator via cfe-commits
weiwang updated this revision to Diff 286467. weiwang added a comment. coding style change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Dri

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-08-18 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. Hi Wei, this looks handy! Minor stylish comments below. Comment at: clang/include/clang/Driver/Driver.h:638 +/// This checks for clang specific R-value ('-Rpass-*') group. +bool hasRpassOptions(const llvm::opt::ArgList &Args); + Nitpickin

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-08-17 Thread Wei Wang via Phabricator via cfe-commits
weiwang updated this revision to Diff 286204. weiwang added a comment. move some unrelated change into parent diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/include/clang/Driver/Driver

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-08-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: lld/ELF/Options.td:595 HelpText<"Alias for --lto-obj-path=">; +def: J<"plugin-opt=opt-remarks-filename=">, + Alias, The change should be moved to a previous patch which will add `--opt-remarks-*` options. Reposito