[PATCH] D83519: [NewPM] Support optnone under new pass manager

MaskRay added inline comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:77 + StandardInstrumentations(bool DebugLogging) + : PrintIR(), TimePasses(), OptNone(DebugLogging) {} (No need to change) PrintIR & TimePasses don't need to ap

[PATCH] D83519: [NewPM] Support optnone under new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rGb13b85818218: [NewPM] Support optnone under new pass manager (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://review

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks updated this revision to Diff 279563. aeubanks added a comment. Rename OptNoneInstrumentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://reviews.llvm.org/D83519 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/inclu

[PATCH] D83519: [NewPM] Support optnone under new pass manager

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM with one nit. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:57 +class OptNoneInstrumentation { +public: ychen wrote: > I may probably

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks updated this revision to Diff 279313. aeubanks marked 4 inline comments as done. aeubanks added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://reviews.llvm.org/D83519 Files: clang/lib/CodeGe

[PATCH] D83519: [NewPM] Support optnone under new pass manager

ychen added inline comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:57 +class OptNoneInstrumentation { +public: I may probably name this `SkipPassInstrumentation`. But it is up to you. Comment at: llvm/include/llvm/Pa

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks added a comment. In D83519#2158938 , @ychen wrote: > In D83519#2144616 , @aeubanks wrote: > > > In D83519#2144463 , @aeubanks > > wrote: > > > > > In D83519#2144403

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks updated this revision to Diff 278871. aeubanks added a comment. Remove required passes part Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://reviews.llvm.org/D83519 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/

[PATCH] D83519: [NewPM] Support optnone under new pass manager

ychen added a comment. In D83519#2144616 , @aeubanks wrote: > In D83519#2144463 , @aeubanks wrote: > > > In D83519#2144403 , @ychen wrote: > > > > > High-level request: how a

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks added a comment. In D83519#2144463 , @aeubanks wrote: > In D83519#2144403 , @ychen wrote: > > > High-level request: how about split this patch into two, the first for the > > `require` pass part; the secon

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added a comment. In D83519#2144403 , @ychen wrote: > High-level request: how about split this patch into two, the first for the > `require` pass part; the second for the PassInstrument callback. Then we

[PATCH] D83519: [NewPM] Support optnone under new pass manager

ychen added a comment. High-level request: how about split this patch into two, the first for the `require` pass part; the second for the PassInstrument callback. Then we could discuss the choices of first patch and D82344 . Comment at: llvm/i

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto &C : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any(&IR)); + ShouldRun &= C(Pass.name(), Pass.is

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto &C : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any(&IR)); + ShouldRun &= C(Pass.name(), Pass.is

[PATCH] D83519: [NewPM] Support optnone under new pass manager

ychen added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto &C : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any(&IR)); + ShouldRun &= C(Pass.name(), Pass.isRequired(), llvm::Any(&IR)); return Shoul

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks created this revision. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, cfe-commits, jfb, dexonsmith, steven_wu, hiraditya. Herald added projects: clang, LLVM. This uses pass instrumentation callbacks to skip optional passes. PassInfoMixin now declares that passes