[PATCH] D83183: [clang] Rework how and when APValues are dumped

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf63e3ea558bb: [clang] Rework how and when APValues are dumped (authored by riccibruno). Changed prior to commit: https:

[PATCH] D83183: [clang] Rework how and when APValues are dumped

This revision was automatically updated to reflect the committed changes. Closed by commit rGf63e3ea558bb: [clang] Rework how and when APValues are dumped (authored by riccibruno). Changed prior to commit: https://reviews.llvm.org/D83183?vs=275783&id=275828#toc Repository: rG LLVM Github Mon

[PATCH] D83183: [clang] Rework how and when APValues are dumped

riccibruno marked 2 inline comments as done. riccibruno added a comment. Thanks for your comments! In D83183#2132975 , @aaron.ballman wrote: > Do none of the JSON tests break from this change? No, but only because I am not modifying the JSON output at

[PATCH] D83183: [clang] Rework how and when APValues are dumped

riccibruno updated this revision to Diff 275713. riccibruno added a comment. Format the tests and make them more relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83183/new/ https://reviews.llvm.org/D83183 Files: clang/include/clang/AST/AP

[PATCH] D83183: [clang] Rework how and when APValues are dumped

aaron.ballman added a comment. Do none of the JSON tests break from this change? Comment at: clang/include/clang/AST/TextNodeDumper.h:163 + raw_ostream &getOS() { return OS; } + This is a pretty strange public method; any way to limit its visibility? =

[PATCH] D83183: [clang] Rework how and when APValues are dumped

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Import/switch-stmt/test.cpp:8 // CHECK-NEXT: ConstantExpr +// CHECK-NEXT: value: Int 1 // CHECK-NEXT: IntegerLiteral

[PATCH] D83183: [clang] Rework how and when APValues are dumped

riccibruno updated this revision to Diff 275783. riccibruno added a comment. Make `dumpAPValueChildren` a private member function and remove `TextNodeDumper::getOS`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83183/new/ https://reviews.llvm.org

[PATCH] D83183: [clang] Rework how and when APValues are dumped

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, steveire, ilya-biryukov, sammccall, martong. riccibruno added a project: clang. Herald added subscribers: cfe-commits, rnkovacs. Currently `APValue`s are dumped as a single string. This becomes quickly completely unread