aaron.ballman added a comment.
Do none of the JSON tests break from this change?
================
Comment at: clang/include/clang/AST/TextNodeDumper.h:163
+ raw_ostream &getOS() { return OS; }
+
----------------
This is a pretty strange public method; any way to limit its visibility?
================
Comment at: clang/test/Import/switch-stmt/test.cpp:8
// CHECK-NEXT: ConstantExpr
+// CHECK-NEXT: value: Int 1
// CHECK-NEXT: IntegerLiteral
----------------
I sort of wonder whether we want both the text and the JSON dumpers to dump
these as: `value(type): <val>`, as that seems like it produces results that are
a bit more well-structured. WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83183/new/
https://reviews.llvm.org/D83183
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
