[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8090d83fd92: [HIP] Do not call opt/llc for -fno-gpu-rdc (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

ashi1 accepted this revision. ashi1 added a comment. LGTM, thank you for splitting the cuda-phases from hip-phases, and opening up a follow-up patch for RDC case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627 ___

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

yaxunl added a comment. In D81627#2090499 , @tra wrote: > LGTM. Good to go if @arsenm is OK with fixing -fgpu-rdc in a separate patch. @arsenm Are you OK with fixing -fgpu-rdc in a separate patch? The fix for that is orthogonal to the current patch. Mi

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Good to go if @arsenm is OK with fixing -fgpu-rdc in a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627 ___

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2725-2726 for (unsigned I = 0, E = GpuArchList.size(); I != E; ++I) { // Create a link action to link device IR with device library // and

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

yaxunl updated this revision to Diff 270302. yaxunl marked 2 inline comments as done. yaxunl added a reviewer: ashi1. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627 Files: clang/lib/Driver/

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

yaxunl added a comment. In D81627#2088502 , @arsenm wrote: > In D81627#2088500 , @arsenm wrote: > > > It doesn't matter if we don't support isa linking. We should just use clang > > and default to -flto. LTO "just

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

arsenm added a comment. In D81627#2088500 , @arsenm wrote: > It doesn't matter if we don't support isa linking. We should just use clang > and default to -flto. LTO "just works" as is This is a step forward, but the lack of ISA linking shouldn't block e

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

arsenm added a comment. It doesn't matter if we don't support isa linking. We should just use clang and default to -flto. LTO "just works" as is CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627 ___ c

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

tra added a comment. Looks OK in general. I'm happy to see reduced opt/llc use. You may want to get someone more familiar with the AMD GPU compilation process to double-check that the compilation pipeline still does the right thing. Comment at: clang/lib/Driver/Driver.cpp:272

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: tpr. Currently HIP toolchain calls clang to emit bitcode then calls opt/llc for device compilation for the default -fno-gpu-rdc case, which is unnecessary since clang is able to compile a single source file to