yaxunl added a comment. In D81627#2090499 <https://reviews.llvm.org/D81627#2090499>, @tra wrote:
> LGTM. Good to go if @arsenm is OK with fixing -fgpu-rdc in a separate patch. @arsenm Are you OK with fixing -fgpu-rdc in a separate patch? The fix for that is orthogonal to the current patch. Mixing them together will clutter things up. Also the need for -fgpu-rdc is not so urgent since only rccl needs it. Requesting this patch to fix -fgpu-rdc will delay fixing issues for all other math libs and frameworks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
