This revision was automatically updated to reflect the committed changes.
aaronpuchert marked an inline comment as done.
Closed by commit rGf70912f885f9: Thread safety analysis: Add note for double
unlock (authored by aaronpuchert).
Changed prior to commit:
https://reviews.llvm.org/D81352?vs=26
aaronpuchert marked 2 inline comments as done.
aaronpuchert added inline comments.
Comment at: clang/include/clang/Analysis/Analyses/ThreadSafety.h:111
/// \param Loc -- The SourceLocation of the Unlock
+ /// \param LocPreviousUnlock -- Optionally the location of a previous U
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a nit.
Comment at: clang/include/clang/Analysis/Analyses/ThreadSafety.h:111
/// \param Loc -- The SourceLocation of the Unlock
+ /// \param
aaronpuchert created this revision.
aaronpuchert added reviewers: aaron.ballman, delesley.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When getting a warning that we release a capability that isn't held it's
sometimes not clear why. So just like we do for double locking,