[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1ba7241c3ef: [clang-tidy] simplify-bool-expr ignores template instantiations (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/ https://reviews.llvm.org/D81336 ___ cfe-commits mailing list cfe-comm

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG, unless @aaron.ballman has concerns. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/ https://reviews.llvm.org/D81336

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

njames93 updated this revision to Diff 271047. njames93 added a comment. Removed `isExpansionInMainFile` check as per original authors comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/ https://reviews.llvm.org/D81336 Files: clang-

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

lebedev.ri added a comment. In D81336#2091833 , @aaron.ballman wrote: > In D81336#2090708 , > @LegalizeAdulthood wrote: > > > Yeah, the restriction to the header file is a bug. It was a misconception > > on my p

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

aaron.ballman added a comment. In D81336#2090708 , @LegalizeAdulthood wrote: > Yeah, the restriction to the header file is a bug. It was a misconception on > my part when I originally wrote the matcher. Excellent, thank you for weighing in! I'm fine w

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

LegalizeAdulthood added a comment. Yeah, the restriction to the header file is a bug. It was a misconception on my part when I originally wrote the matcher. See https://bugs.llvm.org/show_bug.cgi?id=26332 which should also be fixed by the change here. I had attempted to make progress on fixin

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

steveire added a comment. This isn't needed if https://reviews.llvm.org/D80961 is merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/ https://reviews.llvm.org/D81336 ___ cfe-commits mailin

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

njames93 updated this revision to Diff 269076. njames93 added a comment. Added back isExpansionInMainFile check Should put a follow up to query removing this check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/ https://reviews.llvm.org/

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

aaron.ballman added a subscriber: LegalizeAdulthood. aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:425 Finder->addMatcher( - ifStmt(isExpansionInMainFile(), hasCondition(cxxBoolLiteral

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:425 Finder->addMatcher( - ifStmt(isExpansionInMainFile(), hasCondition(cxxBoolLiteral(equals(Value))

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:425 Finder->addMatcher( - ifStmt(isExpansionInMainFile(), hasCondition(cxxBoolLiteral(equals(Value)).bind(BooleanId))) nj

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:425 Finder->addMatcher( - ifStmt(isExpansionInMainFile(), hasCondition(cxxBoolLiteral(equals(Value))

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:425 Finder->addMatcher( - ifStmt(isExpansionInMainFile(), hasCondition(cxxBoolLiteral(equals(Value)).bind(BooleanId))) Th

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

lebedev.ri added a comment. Thank you for looking into it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81336/new/ https://reviews.llvm.org/D81336 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, lebedev.ri, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Ignore template instantiations in the matchers, Addresses readability-simplify-boolean-expr false-positive for