njames93 marked an inline comment as done.
njames93 added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:425
Finder->addMatcher(
- ifStmt(isExpansionInMainFile(),
hasCondition(cxxBoolLiteral(equals(Value)).bind(BooleanId)))
----------------
aaron.ballman wrote:
> This is changing the behavior so that now it will diagnose in header files,
> no? Why is the correct change to replace this with
> `unless(isInTemplateInstantiation())` instead of adding the new matcher?
It's changing behaviour that arguably shouldn't have been in the first place.
But perhaps that change should go on a new patch or update the description of
this one
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81336/new/
https://reviews.llvm.org/D81336
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
