[PATCH] D81242: [StackSafety] Run ThinLTO

tejohnson added a comment. In D81242#2190041 , @vitalybuka wrote: > In D81242#2188467 , @tejohnson wrote: > >> In D81242#2188441 , @vitalybuka >> wrote: >> >>> In D81242#218

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added a comment. In D81242#2188467 , @tejohnson wrote: > In D81242#2188441 , @vitalybuka > wrote: > >> In D81242#2183383 , @tejohnson >> wrote: >> >>> Is the sta

[PATCH] D81242: [StackSafety] Run ThinLTO

tejohnson added a comment. In D81242#2188441 , @vitalybuka wrote: > In D81242#2183383 , @tejohnson wrote: > >> Is the stack safety analysis meant to be always on with ThinLTO? > > During compilation most of the time

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added a comment. In D81242#2183383 , @tejohnson wrote: > Is the stack safety analysis meant to be always on with ThinLTO? During compilation most of the time it should be off. However during linking I assume that most build FS->paramAccesses()

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added a comment. Thanks. Looking. In D81242#2183383 , @tejohnson wrote: > I just noticed that generateParamAccessSummary is taking a bit over 5% of the > ThinLTO thin link step in an internal build (and will soon be more than 5% as > I found

[PATCH] D81242: [StackSafety] Run ThinLTO

tejohnson added a comment. In D81242#2183383 , @tejohnson wrote: > I just noticed that generateParamAccessSummary is taking a bit over 5% of the > ThinLTO thin link step in an internal build (and will soon be more than 5% as > I found another analysis th

[PATCH] D81242: [StackSafety] Run ThinLTO

tejohnson added a comment. I just noticed that generateParamAccessSummary is taking a bit over 5% of the ThinLTO thin link step in an internal build (and will soon be more than 5% as I found another analysis that is hogging compile time that I'm going to work on fixing). This is currently the s

[PATCH] D81242: [StackSafety] Run ThinLTO

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1e47b47f884: [StackSafety] Run ThinLTO (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added inline comments. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if (Access.signedAddMayOverflow(C.Offset) != +ConstantRange::OverflowResult::NeverOverflows) -

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka updated this revision to Diff 270553. vitalybuka marked 3 inline comments as done. vitalybuka added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242 Files: clang/test

[PATCH] D81242: [StackSafety] Run ThinLTO

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM with 2 notes Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if (Access.signedA

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added inline comments. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if (Access.signedAddMayOverflow(C.Offset) != +ConstantRange::OverflowResult::NeverOverflows) -

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka updated this revision to Diff 270328. vitalybuka marked 5 inline comments as done. vitalybuka added a comment. @eugenis review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242 Files: clang/test/

[PATCH] D81242: [StackSafety] Run ThinLTO

eugenis added inline comments. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if (Access.signedAddMayOverflow(C.Offset) != +ConstantRange::OverflowResult::NeverOverflows)

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM. ThinLTO linking runs dataflow processing on collected function parameters. Then StackSa