eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land.
LGTM with 2 notes ================ Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 + ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); + if (Access.signedAddMayOverflow(C.Offset) != + ConstantRange::OverflowResult::NeverOverflows) ---------------- vitalybuka wrote: > eugenis wrote: > > Do we have a test for this overflow check? > yes > Example, in bit width 8 > [-128,-127)+[-128,-127) = [0,1) > both non-wrapped and result is non-wrapped so we have no way to spot overflow Sure. I was asking if we have a testcase that covers the overflow check. ================ Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:926 + } + // Reset data for all sammaries. Alive and DSO local will be set back from + // of data flow results below. Anything else will not be accessed ---------------- typo: summaries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
