This revision was automatically updated to reflect the committed changes.
Closed by commit rG3f353a2e5a98: [BFloat] Add convert/copy instrinsic support
(authored by miyuki).
Changed prior to commit:
https://reviews.llvm.org/D80928?vs=272406&id=272731#toc
Repository:
rG LLVM Github Monorepo
stuij accepted this revision.
stuij added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80928/new/
https://reviews.llvm.org/D80928
___
cfe-commits mailing list
cfe-commits@lis
miyuki marked 5 inline comments as done.
miyuki added inline comments.
Comment at: clang/utils/TableGen/NeonEmitter.cpp:1066
if (Name == "vcvt_f16_f32" || Name == "vcvt_f32_f16" ||
+ Name == "vcvt_f32_f64" || Name == "vcvt_f64_f32" ||
LukeGeeson wrote:
miyuki updated this revision to Diff 272406.
miyuki added a comment.
1. Rebased and fixed failures
2. Added a test for AArch64 codegen of lane copying intrinsics
3. Addressed reviewers' comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80928/new/
https://reviews.llvm.org/D80928
Fi
ostannard added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsARM.td:789
+def int_arm_neon_vcvtfp2bf
+: Intrinsic<[llvm_anyvector_ty], [llvm_anyvector_ty], [IntrNoMem]>;
I only see this being used for f32 -> bf16 conversion, so could this have
miyuki added inline comments.
Comment at: llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp:4675
+ SDValue Ops[] = { Src, Pred, Reg0 };
+ CurDAG->SelectNodeTo(N, ARM::BF16_VCVT, MVT::v4i16, Ops);
+ return;
Why does it return `MVT::v4i16`, not `MVT::v4bf16`?
LukeGeeson added a comment.
A few nits, it looks largely uncontroversial but I'll let someone else give the
ok since an external eye is always good :)
Comment at: clang/utils/TableGen/NeonEmitter.cpp:1066
if (Name == "vcvt_f16_f32" || Name == "vcvt_f32_f16" ||
+ Name
labrinea created this revision.
labrinea added reviewers: fpetrogalli, LukeGeeson, stuij, momchil.velikov,
SjoerdMeijer, miyuki.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added projects: clang, LLVM.
This patch is part of a series implementing the Bfloat16 extension of the
Armv8
