This revision was automatically updated to reflect the committed changes.
Closed by commit rG37e72f47a41d: [PowerPC] Add -m[no-]power10-vector clang and
llvm option (authored by saghir).
Changed prior to commit:
https://reviews.llvm.org/D80758?vs=268893&id=271179#toc
Repository:
rG LLVM Gith
saghir updated this revision to Diff 268893.
saghir added a comment.
Updated the diff based on latest changes in master.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80758/new/
https://reviews.llvm.org/D80758
Files:
clang/include/clang/Driver/O
saghir updated this revision to Diff 268031.
saghir marked an inline comment as done.
saghir removed a reviewer: power-llvm-team.
saghir added a comment.
Herald added a subscriber: kbarton.
Addressed nit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
lei accepted this revision.
lei added a comment.
LGTM.
Minor nit can be addressed during commit.
Comment at: clang/lib/Basic/Targets/PPC.cpp:413
+ Features["power9-vector"] = Features["power10-vector"] = false;
+if (Name == "power9-vector")
+ Features["power10-ve
saghir updated this revision to Diff 267859.
saghir added a comment.
Removed `P10Altivec`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80758/new/
https://reviews.llvm.org/D80758
Files:
clang/include/clang/Driver/Options.td
clang/lib/Basic/Ta
saghir marked 2 inline comments as done.
saghir added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.cpp:414
+if (Name == "power9-vector")
+ Features["power10-vector"] = false;
Features[Name] = false;
lei wrote:
> I think it would be good
lei added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.cpp:414
+if (Name == "power9-vector")
+ Features["power10-vector"] = false;
Features[Name] = false;
I think it would be good to change this into a switch-stmt as there are enough
co
amyk accepted this revision.
amyk added a comment.
This revision is now accepted and ready to land.
This LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80758/new/
https://reviews.llvm.org/D80758
_
saghir created this revision.
saghir added reviewers: hfinkel, nemanjai, lei, power-llvm-team, amyk.
saghir added projects: LLVM, clang.
Herald added subscribers: llvm-commits, cfe-commits, shchenz, hiraditya.
jsji added a reviewer: PowerPC.
jsji added a project: PowerPC.
This patch adds command l
