lei added inline comments.
================
Comment at: clang/lib/Basic/Targets/PPC.cpp:414
+ if (Name == "power9-vector")
+ Features["power10-vector"] = false;
Features[Name] = false;
----------------
I think it would be good to change this into a switch-stmt as there are enough
conditional changed based on `Name` and probably more to come.
================
Comment at: llvm/lib/Target/PowerPC/PPC.td:219
FeatureP9Altivec]>;
+def FeatureP10Altivec : SubtargetFeature<"power10-altivec", "HasP10Altivec",
+ "true",
----------------
what's the relationship between this and p10 vector support?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80758/new/
https://reviews.llvm.org/D80758
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
