[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 closed this revision. usaxena95 added a comment. Closed with commit 158af0d3d165c0382a6a291e81ffecf0b18ffe77 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/Quality.h:129 + // Properties and utilites used to compute derived signals. These are ignored + // by a scoring function. Must be explicitly assigned. sammccall wrote: > Why is it better to

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 updated this revision to Diff 293706. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79500/new/ https://reviews.llvm.org/D79500 Files: clang-tool

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:112 SymbolRelevanceSignals Relevance; -Relevance.Name = Sym.Name; Relevance.Query = SymbolRelevanceSignals::Generic; why this change? Comment at

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 updated this revision to Diff 262852. usaxena95 added a comment. - Added DerivedSignals struct containing all the derived signals. - Added NameMatchesContext and proximtiy signals to this struct. - We need to call computeDerivedSignals() before calling evaluate() if we set non-concrete

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Current implementation of heuristic-based scoring function also contains computation of derived signal