[PATCH] D79106: [clangd] Move inserted include from detail -> documentation.

2020-04-30 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG54d7db165d43: [clangd] Move inserted include from detail -> documentation. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D79106?vs=260962&id=261298#toc Repository: rG LLV

[PATCH] D79106: [clangd] Move inserted include from detail -> documentation.

2020-04-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added a comment. This needed a nontrivial merge after D79157 , because we need to concatenate markup::Documents. Don't think there's anything surprising in there so going ahead, happy to address any comments t

[PATCH] D79106: [clangd] Move inserted include from detail -> documentation.

2020-04-30 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1834 if (InsertInclude) -LSP.detail += "\n" + InsertInclude->Header; - LSP.documentation = Documentation; +

[PATCH] D79106: [clangd] Move inserted include from detail -> documentation.

2020-04-29 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Many clients try to display all the detail inline, with poor results. Repository: rG LLVM