hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1834 if (InsertInclude) - LSP.detail += "\n" + InsertInclude->Header; - LSP.documentation = Documentation; + LSP.documentation = llvm::formatv("#include {0}", InsertInclude->Header); + if (!Documentation.empty()) { ---------------- `#include` => `From`, IIUC discussion from the chat. maybe worth a comment explaining why we make such a decision, the description seems good enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79106/new/ https://reviews.llvm.org/D79106 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits