steakhal added inline comments.
Comment at:
clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19
+#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h"
+#include "llvm/Config/config.h"
+#include "gtest/gtest.h"
steakhal wrote:
> whispe
steakhal added inline comments.
Comment at:
clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19
+#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h"
+#include "llvm/Config/config.h"
+#include "gtest/gtest.h"
whisperity wrote:
> stea
whisperity added inline comments.
Comment at:
clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19
+#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h"
+#include "llvm/Config/config.h"
+#include "gtest/gtest.h"
steakhal wrote:
> mgor
steakhal added inline comments.
Comment at:
clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19
+#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h"
+#include "llvm/Config/config.h"
+#include "gtest/gtest.h"
mgorny wrote:
> `config.
mgorny added a comment.
This commit breaks standalone clang builds.
Comment at:
clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19
+#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h"
+#include "llvm/Config/config.h"
+#include "gtest/gtest.h"
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe22cae32c5c4: [analyzer][NFC] Add unittest for
FalsePositiveRefutationBRVisitor (authored by steakhal).
Changed prior to commit:
https://reviews.llvm.org/D78704?vs=260104&id=274133#toc
Repository:
rG
gribozavr2 added a comment.
I reverted your commit because it seemed to have broken the build:
FalsePositiveRefutationBRVisitorTest.cpp:112:3: error: use of undeclared
identifier 'LLVM_WITH_Z3'
https://github.com/llvm/llvm-project/commit/a44425f25b5ca417e7ecee6e7e00040224e50a69
CHANGES SINC
steakhal updated this revision to Diff 260104.
steakhal edited the summary of this revision.
steakhal added a comment.
- added `GTEST_SKIP` FIXME comment
- reformatted the summary of the patch
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78704/new/
https://reviews.llvm.org/D78704
File
martong accepted this revision.
martong added a comment.
Other than Whispy's nits, LGTM!
Comment at:
clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:24
+ do
\
+if (!LLVM_WIT
whisperity added inline comments.
Comment at:
clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:24
+ do
\
+if (!LLVM_WITH_Z3)
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
I think this should not be blocked on the gtest update. If getting an updated
gtest into the repo takes to much time and the reviewers are happy, I'm fine
with doing that change as a fol
xazax.hun added inline comments.
Comment at:
clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:24
+ do
\
+if (!LLVM_WITH_Z3)
steakhal marked 4 inline comments as done.
steakhal added a comment.
I addressed most of the comments.
Comment at: clang/unittests/StaticAnalyzer/CheckerRegistration.h:81
+template
+bool runCheckerOnCodeWithArgs(const std::string &Code, std::string &Diags,
+
steakhal updated this revision to Diff 259668.
steakhal marked 6 inline comments as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78704/new/
https://reviews.llvm.org/D78704
Files:
clang/unittests/StaticAnalyzer/CMakeLists.txt
clang/unittes
martong added inline comments.
Comment at:
clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:65
+
+ bool reportIfCanBeZero(const CallEvent &Call, CheckerContext &C,
+ ProgramStateRef State) const {
xazax.hun wrote:
martong added inline comments.
Comment at:
clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:55
+
+ bool reachedWithNoContradiction(const CallEvent &, CheckerContext &C,
+ ProgramStateRef State) const {
It
martong added a comment.
I like it! Nice work! I have some minor comments.
Comment at: clang/unittests/StaticAnalyzer/CheckerRegistration.h:81
+template
+bool runCheckerOnCodeWithArgs(const std::string &Code, std::string &Diags,
+ const std::vector
xazax.hun added a comment.
Thanks! Having more tests is always welcome!
I mentioned some nits inline, but I wonder if you actually need to add a new
check. Can't you just reuse existing debug checks?
We have the expr inspeciton checker that supports the following functions:
clang_analyzer_war
steakhal created this revision.
steakhal added reviewers: NoQ, xazax.hun, rnkovacs, Szelethus,
baloghadamsoftware, mikhail.ramalho.
Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso,
dkrupp, donat.nagy, a.sidorin, szepet, whisperity, mgorny.
Herald added a project: clang.
st
steakhal updated this revision to Diff 259531.
steakhal added a comment.
Upload the right diff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78704/new/
https://reviews.llvm.org/D78704
Files:
clang/unittests/StaticAnalyzer/CMakeLists.txt
clang
20 matches
Mail list logo
