martong added a comment. I like it! Nice work! I have some minor comments.
================ Comment at: clang/unittests/StaticAnalyzer/CheckerRegistration.h:81 +template <AddCheckerFn... Fns> +bool runCheckerOnCodeWithArgs(const std::string &Code, std::string &Diags, + const std::vector<std::string> &Args, ---------------- Do you use this function template anywhere? ================ Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:138 + std::string Diags2; + EXPECT_TRUE(runFalsePositiveGeneratorOnCode(Code, Diags2)); + EXPECT_EQ(Diags2, "test.FalsePositiveGenerator:REACHED_WITH_CONTRADICTION\n"); ---------------- There is no need to have `Diags2`. You could reuse `Diags` if in `runFalsePositiveGeneratorOnCode` you cleared the diag param. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78704/new/ https://reviews.llvm.org/D78704 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
