This revision was automatically updated to reflect the committed changes.
Closed by commit rG0f12480bd13a: [dfsan] Add "DataFlow" option to
LLVM_USE_SANITIZER (authored by zbrid).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78390/new/
https://revi
zbrid added a comment.
Bug: https://bugs.llvm.org/show_bug.cgi?id=45621
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78390/new/
https://reviews.llvm.org/D78390
___
cfe-commits mailing list
cfe-commits
zbrid updated this revision to Diff 258789.
zbrid added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78390/new/
https://reviews.llvm.org/D78390
Files:
clang/docs/DataFlowSanitizer.rst
libcxx/CMakeLists.txt
libcxx/utils/lib
zbrid added a comment.
Gonna land this and file a bug for the failing tests. The tests shouldn't block
anyone upstream since I'm only adding a build mode. I'll do some more digging
into those failures in the future.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://rev
zbrid updated this revision to Diff 258608.
zbrid added a comment.
- Remove dfsan feature based on review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78390/new/
https://reviews.llvm.org/D78390
Files:
clang/docs/DataFlowSanitizer.rst
zbrid updated this revision to Diff 258462.
zbrid added a comment.
Update nit from Matt
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78390/new/
https://reviews.llvm.org/D78390
Files:
clang/docs/DataFlowSanitizer.rst
libcxx/CMakeLists.txt
li
zbrid marked an inline comment as done.
zbrid added inline comments.
Comment at: libcxx/utils/libcxx/test/config.py:914
+self.cxx.flags += ['-fsanitize=dataflow']
+self.config.available_features.add('dfsan')
else:
broa
morehouse accepted this revision.
morehouse added inline comments.
Comment at: clang/docs/DataFlowSanitizer.rst:23
+How to build
+
Nit: "How to build libc++"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
broadwaylamb added inline comments.
Comment at: libcxx/utils/libcxx/test/config.py:914
+self.cxx.flags += ['-fsanitize=dataflow']
+self.config.available_features.add('dfsan')
else:
I'm not sure we need a new feature if
zbrid updated this revision to Diff 258447.
zbrid added a comment.
Update documentation based on Matt's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78390/new/
https://reviews.llvm.org/D78390
Files:
clang/docs/DataFlowSanitizer.rst
morehouse added inline comments.
Comment at: clang/docs/DataFlowSanitizer.rst:24
+How to build
+
+
Let's add some explanation here about why we want to build libc++ with dfsan.
Comment at: clang/docs/DataFlowSanitizer.rst:26
+
+Buil
zbrid updated this revision to Diff 258383.
zbrid added a comment.
Herald added a subscriber: broadwaylamb.
Update config.py to support data flow sanitizer
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78390/new/
https://reviews.llvm.org/D78390
Fi
zbrid added a comment.
Oh I found some lit tests that fail by running `check-cxx`. I'll address that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78390/new/
https://reviews.llvm.org/D78390
___
cfe-co
zbrid created this revision.
zbrid added a reviewer: morehouse.
Herald added subscribers: libcxx-commits, cfe-commits, mgorny.
Herald added projects: clang, libc++.
Herald added a reviewer: libc++.
zbrid added a reviewer: EricWF.
zbrid edited the summary of this revision.
This patch add the datafl
14 matches
Mail list logo
