[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

This revision was automatically updated to reflect the committed changes. lei marked an inline comment as done. Closed by commit rG10b60dde7670: [PowerPC] Refactor ppcUserFeaturesCheck() (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

jsji accepted this revision. jsji added a comment. LGTM. Since there is an improvement for multi errors, we should remove `[NFC]` in title and commit messages. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.o

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei updated this revision to Diff 258375. lei added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Driver/ppc-depend

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei marked an inline comment as done. lei added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:243 + bool Passed = CheckVSXSubfeature("+power8-vector", "-mpower8-vector"); + Passed |= CheckVSXSubfeature("+direct-move", "-mdirect-move"); + Passed |= CheckVSXSubfea

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

jsji added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:243 + bool Passed = CheckVSXSubfeature("+power8-vector", "-mpower8-vector"); + Passed |= CheckVSXSubfeature("+direct-move", "-mdirect-move"); + Passed |= CheckVSXSubfeature("+float128", "-mfloat128");

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for refactoring this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 _

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei updated this revision to Diff 258175. lei added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 Files: clang/lib/Basic/Targets/PPC.cpp Index: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei updated this revision to Diff 258121. lei added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 Files: clang/lib/Basic/Targets/PPC.cpp Index: clang/lib/Basic/Targets/PPC.cpp ==

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei updated this revision to Diff 258119. lei added a comment. Fix mistake in code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 Files: clang/lib/Basic/Targets/PPC.cpp Index: clang/lib/Basic/Targets/P

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

lei created this revision. lei added reviewers: nemanjai, stefanp. Herald added subscribers: shchenz, kbarton. Herald added a project: clang. This function keeps growing, refactor to use lambda. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78308 Files: clang/lib/Basic/Targ