[PATCH] D78048: [clangd] Add tests that no-op changes are cheap

2020-04-14 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG808c2855e116: [clangd] Add tests that no-op changes are cheap (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D78048?vs=257083&id=2

[PATCH] D78048: [clangd] Add tests that no-op changes are cheap

2020-04-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:501 +MATCHER_P4(Stats, Name, UsesMemory, PreambleBuilds, ASTBuilds, "") { + return arg.first() == Name && (arg.second.UsedBytes != 0) == Us

[PATCH] D78048: [clangd] Add tests that no-op changes are cheap

2020-04-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for doing this LGTM! Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:501 +MATCHER_P4(Stats, Name, UsesMemory, PreambleBuilds, ASTBuilds, "") { + re

[PATCH] D78048: [clangd] Add tests that no-op changes are cheap

2020-04-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. sammccall updated this revision to Diff 257083. sammccall added a comment. format

[PATCH] D78048: [clangd] Add tests that no-op changes are cheap

2020-04-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 257083. sammccall added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78048/new/ https://reviews.llvm.org/D78048 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/clang