kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks for doing this LGTM!
================
Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:501
+MATCHER_P4(Stats, Name, UsesMemory, PreambleBuilds, ASTBuilds, "") {
+ return arg.first() == Name && (arg.second.UsedBytes != 0) == UsesMemory &&
+ arg.second.PreambleBuilds == PreambleBuilds &&
----------------
nit:
```
std::make_tuple(arg.first(), arg.second.UsedBytes != 0,
arg.second.PreambleBuilds, arg.second.ASTBuilds) == std::tie(Name, UsesMemory,
PreambleBuilds, ASTBuilds);
```
================
Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:762
+ ASSERT_TRUE(DoUpdate(SourceContents));
+ ASSERT_FALSE(DoUpdate(SourceContents));
+ ASSERT_EQ(S.fileStats().lookup(Source).ASTBuilds, 4u);
----------------
nit: maybe we drop these noop updates except the first one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78048/new/
https://reviews.llvm.org/D78048
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
