[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

nickdesaulniers added a comment. In D75850#1915198 , @miyuki wrote: > Should compile without warnings now. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75850/new/ https://reviews.llvm.org/D7

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki marked an inline comment as done. miyuki added a comment. Should compile without warnings now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75850/new/ https://reviews.llvm.org/D75850 ___ cfe-co

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2096 + llvm::APSInt CoprocNoAP; + bool IsICE = CoprocArg->isIntegerConstantExpr(CoprocNoAP, Context); + assert(IsICE && "Coprocossor immediate is not a constant expression"); I

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

This revision was automatically updated to reflect the committed changes. Closed by commit rG47edf5bafb8e: [ARM,CDE] Generalize MVE intrinsics infrastructure to support CDE (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75850/new

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki updated this revision to Diff 249362. miyuki added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75850/new/ https://reviews.llvm.org/D75850 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM with a couple of tiny spelling nitpicks. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:642 def err_arm_invalid_specialreg : Error<"invalid sp

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki added a comment. In D75850#1912810 , @sdesmalen wrote: > but am happy to update my patch to reuse the generic > `__clang_arm_builtin_alias`! Please do. It would be nicer to have a single attribute than 2 or 3 distinct ones which serve essentia

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

sdesmalen added a comment. In D75850#1912685 , @simon_tatham wrote: > > Renames the 'clang_arm_mve_alias' attribute into 'clang_arm_builtin_alias' > > (it will be used with CDE intrinsics as well as MVE intrinsics) > > You might talk to @sdesmalen, who m

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki updated this revision to Diff 249140. miyuki added a comment. Fix linter and formatter warnings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75850/new/ https://reviews.llvm.org/D75850 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/inc

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

simon_tatham added a subscriber: sdesmalen. simon_tatham added a comment. > Renames the 'clang_arm_mve_alias' attribute into 'clang_arm_builtin_alias' > (it will be used with CDE intrinsics as well as MVE intrinsics) You might talk to @sdesmalen, who mentioned introducing an `arm_sve_alias` att

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, kristof.beyls, mgorny. Herald added projects: clang, LLVM. miyuki added a parent revision: D75843: [ARM,CDE] Implement CDE feature