simon_tatham accepted this revision.
simon_tatham added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of tiny spelling nitpicks.
================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:642
def err_arm_invalid_specialreg : Error<"invalid special register for builtin">;
+def err_arm_invalid_invalid_coproc : Error<"coprocessor %0 must be configured"
+ " as %select{GCP|CDE}1">;
----------------
Was this identifier meant to say "invalid" twice?
================
Comment at: clang/include/clang/Sema/Sema.h:11768
+ bool CheckCDEBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall);
+ bool CheckARMCoprocessorImmediate(const Expr *CorpocArg, bool WantCDE);
bool CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall);
----------------
Another "Corpoc" here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75850/new/
https://reviews.llvm.org/D75850
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
