jdoerfert added a comment.
> There should be at most two iterations, one to perform folds and one to
> verify the fixpoint. If there are more iterations, that's a bug in worklist
> management
FWIW, the Attributor uses basically the same scheme. It helps us to monitor
iteration increases/decrea
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf12fb2d99b8d: [IRBuilder] Always respect inserter/folder
(authored by nikic).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74787/new/
https://reviews.llvm.
nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.
LGTM. I think it's a pretty reasonable idea to add this threshold check to
track down things that should be minor, but can add up in terms of compile-time
performance.
Repository:
rG L
nikic marked an inline comment as done.
nikic added inline comments.
Comment at: llvm/test/Transforms/InstCombine/saturating-add-sub.ll:2
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -instcombine -S | FileCheck %s
+; RUN: opt < %s -i
Meinersbur added a comment.
Nice work
Comment at: llvm/test/Transforms/InstCombine/saturating-add-sub.ll:2
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -instcombine -S | FileCheck %s
+; RUN: opt < %s -instcombine -instcombine-infin
nikic created this revision.
nikic added reviewers: nhaehnle, Meinersbur, spatel, lebedev.ri.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added a reviewer: jdoerfert.
Herald added projects: clang, LLVM.
Some IRBuilder methods that were originally defined on IRBuilderBase
