Meinersbur added a comment.

Nice work



================
Comment at: llvm/test/Transforms/InstCombine/saturating-add-sub.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -instcombine -S | FileCheck %s
+; RUN: opt < %s -instcombine -instcombine-infinite-loop-threshold=2 -S | 
FileCheck %s
 
----------------
IMHO how the folding works internally (folded by IRBuilder instead of 
InstCombine rule) does not need to be part of a/this regression test. If 
another test is added to this file requiring 3 rounds, it would raise some 
confusions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74787/new/

https://reviews.llvm.org/D74787



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to