hubert.reinterpretcast added inline comments.
Comment at: llvm/lib/Support/Unix/Path.inc:243
+#elif defined(_AIX)
+ return getLoadModuleFilenameForFunction(MainAddr)->c_str();
#elif defined(__linux__) || defined(__CYGWIN__) || defined(__gnu_hurd__)
hubert.reint
hubert.reinterpretcast requested changes to this revision.
hubert.reinterpretcast added inline comments.
This revision now requires changes to proceed.
Comment at: llvm/lib/Support/Unix/Path.inc:243
+#elif defined(_AIX)
+ return getLoadModuleFilenameForFunction(MainAddr)->c_str(
xingxue accepted this revision.
xingxue added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72736/new/
https://reviews.llvm.org/D72736
___
cfe-commits mailing list
cfe-commit
Jonathan.Crowther updated this revision to Diff 239198.
Jonathan.Crowther added a comment.
Addressed comments by moving `getLoadModuleFilnameForFunction` to
`llvm/lib/Support/SystemUtils.cpp`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72736/new/
https://reviews.llvm.org/D72736
File
stevewan added a comment.
Provided that you have squashed all changes into the latest commit in your
branch, `git diff HEAD^ -U1` should emit the context you need. Adjust the
number of lines of context accordingly to fit the size of your files.
Repository:
rG LLVM Github Monorepo
CHANGE
hubert.reinterpretcast added inline comments.
Comment at: llvm/include/llvm/Support/FileUtilities.h:38
+#if defined(_AIX)
+ SmallString<128> getLoadModuleFilenameForFunctionAIX(void (*Func)(void));
+#endif
This should be an internal function in the `.cpp` file i
hubert.reinterpretcast added inline comments.
Comment at: llvm/include/llvm/Support/FileUtilities.h:44
+if (!FuncAddr) {
+ return "";
+}
I'm not sure that this function should handle failure by returning an empty
string. The error condition can be m
Jonathan.Crowther created this revision.
Jonathan.Crowther added reviewers: hubert.reinterpretcast, xingxue.
Herald added subscribers: llvm-commits, cfe-commits, arphaman, hiraditya.
Herald added projects: clang, LLVM.
Implemented (for AIX) a function to take any function and return the path of
t
