ymandel added inline comments.
Comment at: clang/include/clang/ASTMatchers/Dynamic/Parser.h:167
static llvm::Optional
- parseMatcherExpression(StringRef MatcherCode, Sema *S,
- const NamedValueMap *NamedValues,
- Diagnostics *Er
gribozavr2 added inline comments.
Comment at: clang/include/clang/ASTMatchers/Dynamic/Parser.h:167
static llvm::Optional
- parseMatcherExpression(StringRef MatcherCode, Sema *S,
- const NamedValueMap *NamedValues,
- Diagnostics
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6a3ecf4dc7ec: Allow newlines in AST Matchers in clang-query
files (authored by stephenkelly).
Changed prior to commit:
https://reviews.llvm.org/D71842?vs=235353&id=235370#toc
Repository:
rG LLVM Gith
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some `auto` -> `auto *` nits.
Comment at: clang-tools-extra/clang-query/QueryParser.cpp:243-244
-return new LetQuery(Name, Value);
+au
steveire marked 2 inline comments as done.
steveire added inline comments.
Comment at: clang-tools-extra/clang-query/QueryParser.cpp:243-244
-return new LetQuery(Name, Value);
+auto Q = new LetQuery(Name, Value);
+Q->RemainingContent = Line;
+return Q;
-
steveire marked 9 inline comments as done.
steveire added inline comments.
Comment at: clang-tools-extra/clang-query/Query.cpp:111
+ }
+ int maxLength = firstLine.size();
std::string prefixText = "Matcher: ";
aaron.ballman wrote:
> `MaxLength` an
steveire updated this revision to Diff 235353.
steveire added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71842/new/
https://reviews.llvm.org/D71842
Files:
clang-tools-extra/clang-query/Query.cpp
clang-tools-extra/clang-que
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-query/Query.cpp:106
+ Source.split(Lines, "\n");
+ auto firstLine = Lines[0];
+ Lines.erase(Lines.begin(), Lines.begin() + 1);
`firstLine` should be `FirstLine` and I have a s
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D71842
Files:
clang-tools-extra/clang-query/Query.cpp
clang-tools-extra/clang-query/
