steveire marked 9 inline comments as done.
steveire added inline comments.

================
Comment at: clang-tools-extra/clang-query/Query.cpp:111
+      }
+      int maxLength = firstLine.size();
       std::string prefixText = "Matcher: ";
----------------
aaron.ballman wrote:
> `MaxLength` and perhaps this type should be `unsigned` or `size_t` rather 
> than `int` to avoid the unnecessary type conversion?
This is where `auto` makes most sense, but I made it `unsigned` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71842/new/

https://reviews.llvm.org/D71842



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to