[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

2019-12-20 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Thanks for taking care of this! Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:194 -if (Std != LangStandard::lang_unspecified) // -std take precedence over -x +// Make use of -std iff -x was missing. +if (Type == type

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

2019-12-20 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc2377eae286b: [clang][Tooling] Prefer -x over -std when interpolating (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71727/new/ https

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

2019-12-20 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71727/new/ https://reviews.llvm.org/D71727 ___

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

2019-12-19 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61035 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

2019-12-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, ilya-biryukov. Herald added a project: clang. Currently interpolation logic prefers -std over -x. But the latter is a more strong signal, so this patch inverts the order and only