sammccall added a comment. Thanks for taking care of this!
================ Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:194 - if (Std != LangStandard::lang_unspecified) // -std take precedence over -x + // Make use of -std iff -x was missing. + if (Type == types::TY_INVALID && Std != LangStandard::lang_unspecified) ---------------- Note that type is initialized from guessType, not only -x, so this comment isn't true in general, just for *.h. Example: if CDB contains `clang -std=c++14 foo.cc`, then we'll treat `foo.mm` as obj-c++ rather than c++. (The right thing in that case and probably in general) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71727/new/ https://reviews.llvm.org/D71727 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
