[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)

2019-11-14 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG37abeed8145b: [clangd] Expose value of enumerators to Hover API. (not UI yet) (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D7020

[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)

2019-11-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:984 }}, + {R"cpp(enum Color { RED, [[GR^EEN]], };)cpp", + [](HoverInfo &HI) { kadircet wrote: > could you

[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)

2019-11-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:984 }}, + {R"cpp(enum Color { RED, [[GR^EEN]], };)cpp", + [](HoverInfo &HI)

[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)

2019-11-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: pass - 59972 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)

2019-11-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is part of https://github.com/clangd/clangd/issues/180. Repository: rG LLVM Github Monorepo