sammccall marked 2 inline comments as done.
sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:984
}},
+ {R"cpp(enum Color { RED, [[GR^EEN]], };)cpp",
+ [](HoverInfo &HI) {
----------------
kadircet wrote:
> could you also add a case checking references to enumconstdecl?
> i.e.
> ```
> Color x = GRE^EN;
> ```
Done, this is consistent with the other tests.
I would like to go in the other direction actually, as this is really testing
lots of cases of targetDecl. I think we should verify the types of references
there, and simplify these cases. But that should probably be done across the
board rather than piecemeal.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70209/new/
https://reviews.llvm.org/D70209
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
